ivanovborislav / rtl88x2bu

Realtek RTL88x2BU v5.13.1 (2021-07-02) Wireless Lan Driver for Linux
GNU General Public License v2.0
59 stars 12 forks source link

Compilation error on last ubuntu update #5

Open koranten2 opened 10 months ago

koranten2 commented 10 months ago

CC [M] /mnt/.../rtl88x2bu/rtl88x2bu/os_dep/linux/wifi_regd.o /mnt/.../rtl88x2bu/rtl88x2bu/os_dep/linux/wifi_regd.c: In function ‘rtw_regd_init’: /mnt/.../rtl88x2bu/rtl88x2bu/os_dep/linux/wifi_regd.c:409:36: error: ‘REGULATORY_IGNORE_STALE_KICKOFF’ undeclared (first use in this function) 409 | wiphy->regulatory_flags |= REGULATORY_IGNORE_STALE_KICKOFF; | ^~~~~~~ /mnt/.../rtl88x2bu/os_dep/linux/wifi_regd.c:409:36: note: each undeclared identifier is reported only once for each function it appears in make[2]: [scripts/Makefile.build:260: /mnt/.../rtl88x2bu/rtl88x2bu/os_dep/linux/wifi_regd.o] Error 1 make[1]: [Makefile:2026: /mnt/.../rtl88x2bu/rtl88x2bu] Error 2 make[1]: Leaving directory '/usr/src/linux-headers-6.2.0-36-generic' make: *** [Makefile:2479: modules] Error 2

The above compilation error happened on last ubuntu 22.04 update. It was compiled successfully a month ago. Please, fix this issue!

bigjoncoop commented 10 months ago

Same Exact issue here

Dav1d23 commented 10 months ago

This small patch fix the compilation problem on kernel 6.5.0 (Ubuntu 23.10), it is working afterwards but I'm not sure at all about implications. Will try to use it a bit and see.

diff --git a/os_dep/linux/wifi_regd.c b/os_dep/linux/wifi_regd.c
index 81e1dc7..db8846c 100644
--- a/os_dep/linux/wifi_regd.c
+++ b/os_dep/linux/wifi_regd.c
@@ -405,7 +405,7 @@ int rtw_regd_init(struct wiphy *wiphy)
    wiphy->regulatory_flags &= ~REGULATORY_DISABLE_BEACON_HINTS;
 #endif

-#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 19, 0))
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 19, 0) && LINUX_VERSION_CODE < KERNEL_VERSION(6, 5, 0))
    wiphy->regulatory_flags |= REGULATORY_IGNORE_STALE_KICKOFF;
 #endif

Side note: while compiling, there are quite some warnings now, not sure which ones are real and which ones are not, I'll try to take a look if and when my little knowledge assists me.