search

ivanperez-keera / Yampa

Functional Reactive Programming domain-specific language for efficient hybrid systems
439 stars 50 forks source link

Yampa-0.10.1 test suite failure #10

Closed peti closed 9 years ago

peti commented 9 years ago

Please see http://hydra.cryp.to/build/795273/nixlog/1/raw for a complete build log.

snoyberg commented 9 years ago

Affects Stackage too.

ivanperez-keera commented 9 years ago

The test suite that's failing is due to adding hlint as a test, in an effort to maintain long-term code quality.

The goal is to get to a point when hlint reports no errors. Apart from improving the code, the necessary hlint preferences should be included: some suggestions are just not appropriate.

However, this whole test is obviously non-critical.

What kind of action would you recommend in this case: a) To disable the test by default. (default: False in the cabal file) b) To comment it out until it is passed correctly?

snoyberg commented 9 years ago

Either of those would work for me (assuming cabal test does why I think it does for a disabled test).

ivanperez-keera commented 9 years ago

New version pushed and uploaded to hackage. Cabal test doesn't do anything there (there are no buildable tests). The exit code is 0.

Does that work?

snoyberg commented 9 years ago

Should be good, I'll let you know if I have any problems.

ivanperez-keera commented 9 years ago

@peti does the new version work now? Can we close the issue?

peti commented 9 years ago

Yes, the new version works fine in NixOS: http://hydra.cryp.to/job/nixpkgs/haskell-updates/haskellngPackages.Yampa.x86_64-linux. Thank you for the quick fix!