`bearriver`: `loopPre` is defined twice

ivanperez-keera / dunai

Classic FRP, Arrowized FRP, Reactive Programming, and Stream Programming, all via Monadic Stream Functions

206 stars 32 forks source link

`bearriver`: `loopPre` is defined twice #438

Open ivanperez-keera opened 1 week ago

ivanperez-keera commented 1 week ago

The function loopPre is defined twice: once in FRP.BearRiver, and once in FRP.BearRiver.Loop. Only one definition should be needed.

This prevents FRP.BearRiver from providing an API equivalent to Yampa's.

ivanperez-keera commented 1 week ago

My intuition here would be to just remove the one in FRP.BearRiver, or hide it in FRP.Yampa and re-export FRP.BearRiver.Loop from FRP.Yampa.

pbrinkmeier commented 14 hours ago

Hi, I'd like to work on this issue. The second approach seems less likely to break the API, so I would perhaps go with that?

ivanperez-keera commented 12 hours ago

Great!

Yeah, let's go with the second approach. Can you please structure it this way?

Commit 1: Expose FRP.Yampa.Loop in FRP.Yampa and hide FRP.BearRiver.loopPre.
Commit 2: Document changes in CHANGELOG.

Always reference the issue with . Refs #438. at the end of the commit message summary, etc.

Do you think you can have it ready today? I need to have the next release ready tonight (EOB Pacific time).

pbrinkmeier commented 6 hours ago

I applied the changes in #441. The duplicate definition of loopPre is removed and replaced by re-exports where required. Please check if I understood the task, then I will add a changelog entry.

ivanperez-keera commented 6 hours ago

Thanks! I responded in the PR.