ivansafrin / Polycode

Polycode is a cross-platform framework for creative code.
polycode.org
MIT License
2.38k stars 348 forks source link

Linux build fails with "No rule to make target `../../src/core/PolyCoreServices.o'" #699

Open BinRoot opened 8 years ago

BinRoot commented 8 years ago

I'm on goodbye_cmake 670e1d11ad Here's what I did:

$ cd build/linux
$ make all

Here's the log:

Building [../../src/core/lodepng.cpp]
Building [../../src/core/PolyBasicFileProvider.cpp]
Building [../../src/core/PolyBezierCurve.cpp]
Building [../../src/core/PolyBone.cpp]
Building [../../src/core/PolyCamera.cpp]
Building [../../src/core/PolyClient.cpp]
Building [../../src/core/PolyColor.cpp]
Building [../../src/core/PolyConfig.cpp]
../../src/core/PolyConfig.cpp: In member function ‘const Polycode::String& Polycode::Config::getStringValue(const Polycode::String&, const Polycode::String&) const’:
../../src/core/PolyConfig.cpp:135:10: warning: returning reference to temporary [-Wreturn-local-addr]
   return "undefined";
          ^
Building [../../src/core/PolyCore.cpp]
Building [../../src/core/PolyCoreFileProvider.cpp]
Building [../../src/core/PolyCoreInput.cpp]
make: *** No rule to make target `../../src/core/PolyCoreServices.o', needed by `core'.  Stop.
fodinabor commented 8 years ago

Hey, yes the problem is we have not yet updated any other distros than Mac & Windows... coming soon - but if you can't wait have a look at which files have been removed in https://github.com/ivansafrin/Polycode/commit/4992d52d5eb529619ae9d0257c6d7d18aace7096 and remove them from the makefile as well.

BinRoot commented 8 years ago

Seems like PolySDLCore.cpp is no longer supposed to be used, but it's tangled up in the linux version

fodinabor commented 8 years ago

Uhmm.. It's still used on Linux - but that has to be updated as well..

ghost commented 8 years ago

@fodinabor Do you have a fix in an upcoming commit? I did somewhat of a fix I can push, but if you have one I can leave it be.

fodinabor commented 8 years ago

@sanghakchun https://github.com/ivansafrin/Polycode/compare/goodbye_cmake...fodinabor:goodbye_cmake is my latest changes.. but I guess it does not affect SDL Core - so you are welcome to send your own PR