ivanseidel / LinkedList

🔗 A fully implemented LinkedList made to work with general Microcontrollers and Arduino projects
MIT License
350 stars 118 forks source link

Remove pointer type converting warnings #13

Closed sandeepmistry closed 8 years ago

sandeepmistry commented 8 years ago

I do not see the build failures mentioned in #12 with Arduino IDE 1.6.9 when building for the Uno or Zero.

However, I see the following warnings when Show verbose output during: [*] compilation is checked in the IDE preferences:

In file included from /var/folders/m9/y22yzb0d49x_kws_6jtwdphw0000gn/T/arduino_modified_sketch_235/SimpleIntegerList.pde:11:0:
/Users/smistry/Documents/Arduino/libraries/LinkedList/LinkedList.h: In instantiation of 'LinkedList<T>::LinkedList() [with T = int]':
/var/folders/m9/y22yzb0d49x_kws_6jtwdphw0000gn/T/arduino_modified_sketch_235/SimpleIntegerList.pde:13:42:   required from here
/Users/smistry/Documents/Arduino/libraries/LinkedList/LinkedList.h:101:6: warning: converting 'false' to pointer type 'ListNode<int>*' [-Wconversion-null]
  root=false;
      ^
/Users/smistry/Documents/Arduino/libraries/LinkedList/LinkedList.h:102:6: warning: converting 'false' to pointer type 'ListNode<int>*' [-Wconversion-null]
  last=false;
      ^
/Users/smistry/Documents/Arduino/libraries/LinkedList/LinkedList.h: In instantiation of 'LinkedList<T>::~LinkedList() [with T = int]':
/var/folders/m9/y22yzb0d49x_kws_6jtwdphw0000gn/T/arduino_modified_sketch_235/SimpleIntegerList.pde:13:42:   required from here
/Users/smistry/Documents/Arduino/libraries/LinkedList/LinkedList.h:121:7: warning: converting 'false' to pointer type 'ListNode<int>*' [-Wconversion-null]
  last = false;
       ^
/Users/smistry/Documents/Arduino/libraries/LinkedList/LinkedList.h: In instantiation of 'bool LinkedList<T>::add(T) [with T = int]':
/var/folders/m9/y22yzb0d49x_kws_6jtwdphw0000gn/T/arduino_modified_sketch_235/SimpleIntegerList.pde:26:14:   required from here
/Users/smistry/Documents/Arduino/libraries/LinkedList/LinkedList.h:192:12: warning: converting 'false' to pointer type 'ListNode<int>*' [-Wconversion-null]
  tmp->next = false;
            ^
/Users/smistry/Documents/Arduino/libraries/LinkedList/LinkedList.h: In instantiation of 'T LinkedList<T>::pop() [with T = int]':
/var/folders/m9/y22yzb0d49x_kws_6jtwdphw0000gn/T/arduino_modified_sketch_235/SimpleIntegerList.pde:56:1:   required from here
/Users/smistry/Documents/Arduino/libraries/LinkedList/LinkedList.h:248:13: warning: converting 'false' to pointer type 'ListNode<int>*' [-Wconversion-null]
   tmp->next = false;
             ^
/Users/smistry/Documents/Arduino/libraries/LinkedList/LinkedList.h:256:8: warning: converting 'false' to pointer type 'ListNode<int>*' [-Wconversion-null]
   root = false;
        ^
/Users/smistry/Documents/Arduino/libraries/LinkedList/LinkedList.h:257:8: warning: converting 'false' to pointer type 'ListNode<int>*' [-Wconversion-null]
   last = false;

This change removes them, and will probably also solve #12.

ivanseidel commented 8 years ago

Thanks for collaborating!

ivanseidel commented 8 years ago

closes #12 for now?

sandeepmistry commented 8 years ago

@ivanseidel yes, I would close #12. I just tried building the examples with 1.6.8 prior to these changes, it was building fine on the Uno.

ivanseidel commented 8 years ago

Great! Just bumped version.. should be in the Arduino Library Manager soon.

Thanks again!