search

ivanseidel / tournamenter-obr

Extensão para o Tournamenter que permite pontuar pelo tablet em competições da OBR
4 stars 5 forks source link

Should /tournamenter-obr/ verify if you logged first? #1

Open jnydutra opened 6 years ago

jnydutra commented 6 years ago

When I access this page then I redirected to Pontuador, even if I not logged into tournamenter app

ivanseidel commented 6 years ago

It will allow you to see it, but you wont be able to save or load teams/scores.

Thats the expected behavior

Is that what is happening?

On Fri, Jun 22, 2018, 7:51 PM Jhonny notifications@github.com wrote:

When I access this page i redirected direct to Pontuador, even if I not logged into tournamenter app

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ivanseidel/tournamenter-obr/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AC9Vr_J4s8gWcfjl0QeFt57EmstPRWeRks5t_XT1gaJpZM4U0hJl .

jnydutra commented 6 years ago

Yeah! But isn't better to redirect to /login page? Suppose that an judge mark all scores before verify if it logged? Then it will lost match information when change to login page?

ivanseidel commented 6 years ago

Thats a good point. However, we cannot do a redirect on the server since all files are hosted statically by plugins (they get merged in a "public" folder during initialization).

But, it could be done on the frotend, just after loading the page. If the user is not logged in, then we can make a warning or redirect to login. That would be easier and would allow the session to be checked not only once during load, but at every minute after that maybe?

Can you make this feature?

On Fri, Jun 22, 2018, 10:19 PM Jhonny notifications@github.com wrote:

Yeah! But isn't better to redirect to /login page? Suppose that an judge mark all scores before verify if it logged? Then it will lost match information when change to login page?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ivanseidel/tournamenter-obr/issues/1#issuecomment-399619788, or mute the thread https://github.com/notifications/unsubscribe-auth/AC9Vr0Fm223LXa5ySxcRqIJxj6Q4mddfks5t_Ze5gaJpZM4U0hJl .

jnydutra commented 6 years ago

I will do! Thanks @ivanseidel :D