I've made your awesome calendar compatible with Godot 3.0.1

ivanskodje-godotengine / godot-plugin-calendar-button

A Godot Engine plugin for 2D GUI. This is a "Calendar Button", which allows you to easily select a date for various purposes. As there is currently (v2.2.alpha) no Date objects, I have created my own Date and Calendar classes for reuse.

MIT License

49 stars 13 forks source link

I've made your awesome calendar compatible with Godot 3.0.1 #3

Closed Silenoid closed 3 years ago

Silenoid commented 6 years ago

I needed a calendar, found your calendar that was so cool I spent time reworking it a bit to use it in the latest Godot version.

A couple of changes are just structural, to match Godot new class standards
I chaged partially the algorythm because of deprecated math expression. I found an article that talked about the algorythm you used in your work and I think I didn't make mistake following that logic. I think it'd be better to show the article link on your page in case someone needs it
I've modified the .png button images deleting the sRGB color space that caused some negligible errors
I've deleted the check_position function just because I didn't need it and wanted to avoid error caused by it. It's easy to correct its behaviour (I've written it in the updated script section)

Thank you so much for what you have done with the calendar. It's been a pleasure working on it :)

ivanskodje commented 6 years ago

Sorry for not noticing this sooner. I will take a look at it when I am back home. :+1:

Silenoid commented 6 years ago

Thanks, it's been a pleasure. Remember that I've deleted the whole position checking procedure just because I'm lazy, so it should be re-implemented using the new margin position variables. Also, I'm a little worried as the 3.1 update is going to release and predict (and hope) other things will change and add to the engine.

Silenoid commented 6 years ago

@ivanskodje for the days of the week I've modified the GUI container manually in order to let it position them correctly as intended. I'm very sorry if I'm dumb and messing with the project :( When I can, I'll rewrite the position checking of the popup and add the line of code for adjusting the days disposition

ivanskodje commented 6 years ago

@ivanskodje for the days of the week I've modified the GUI container manually in order to let it position them correctly as intended. I'm very sorry if I'm dumb and messing with the project :( When I can, I'll rewrite the position checking of the popup and add the line of code for adjusting the days disposition

:+1:

ccmorataya commented 5 years ago

How about with this? It will be ready for >3.1

jospic commented 4 years ago

Hi, I've forked original plugin version by Ivan and I've made some improvments as described here: https://github.com/jospic/godot-plugin-calendar-button

Let me know what you think. Regards. -j

ivanskodje commented 3 years ago

In hindsight, please go ahead and make a new PR if you are still able / willing to help out 👍
This will make review easier later on, since a lot in Godot have changed since this was made