search

ivansofeski / Hackademy-IV-frontend

1 stars 5 forks source link

Hac 70 monthly.funding #143

Closed ahmedBazzara closed 7 years ago

ahmedBazzara commented 7 years ago

issue #135

alayham commented 7 years ago

Acceptance criteria: Table of all (funding) closed projects for a set time period. Organization, bank account, project name and amount.

This needs to be improved by adding a date filter, and figuring out how to show the projects that were closed in a specific period.

ahmedBazzara commented 7 years ago

yes. But this as well should be implemented on the back end. and we again we just call it the filtering method from the -said to be done- API. Regarding the fields, i'll edit them now

ahmedBazzara commented 7 years ago

aha. i think i got your comment wrong. i think another field should be added in the backend which has the actual (closing) date of a project. And our task add a filter Date in the closed projects page.

alayham commented 7 years ago

I suggest solving the "closing a project" feature like this: if the project reaches 100% of funding, its closing date is changed to now, which is logical according to Daniels definition of closed projects. this way, all closed projects will be in the past, when you run the report, and you will know exactly when a project was closed. your filter will be on the closing date, and the donor team can add an action to set the closing date when the project reaches 100%.

alayham commented 7 years ago

here is my suggestion for solving this issue. https://github.com/IvanCybercom/Hackademy-IV-frontend/tree/HAC-admin-reporting-module if you like the code, feel free to use it.

albannurkollari commented 7 years ago

Due to merging conflicts on this branch, I hereby am closing this pull request, but, keeping the branch for tracking work history. Please refer to Admin Reports: Closed Projects for the latest updates following this branch work.