search

ivansofeski / Hackademy-IV-frontend

1 stars 5 forks source link

New enhancements on organization page #159

Closed MhdBarazi closed 6 years ago

alayham commented 6 years ago

This update broke a test OrganizationPageComponent Display the name of the organization

if you do not want to display the org name as a field, you can remove the test. I recommend keeping the org name as a field, because the title can be changed if required

MhdBarazi commented 6 years ago

@alayham Try now my branch. New update!

alayham commented 6 years ago

Why are we changing interfaces in this branch?

albannurkollari commented 6 years ago

@alayham It's a rebase thing. My commit is included in his branch/pull request. We rebased the new development with his current branch and it included other commits (mine). Don't know how to remove the commit and repush again.

alayham commented 6 years ago

@albannurkollari why are we changing interfaces at all?

I proposed a solution to close projects without any change in interfaces. did anybody check it?

albannurkollari commented 6 years ago

@alayham I checked the proposed solution. I don't like it (personally). But we all others came to a common sense that we need more properties in the interfaces. So to speak the interfaces I created aren't used anywhere, its for testing purpose also. And why have it on development? Because many other can be able to use them if need be. Btw this is my last comment in here as its becoming very unusual to discuss such matters in here. Either Approve/Not this branch. We all seen @MhdBarazi work, and it's not breaking any test nor runtime errors.

alayham commented 6 years ago

If something does not break, it does not mean it is good. anyway, it is your code. Do what you like.

As for me, I prefer to avoid unnecessary maintenance and redundant information in DB.

MhdBarazi commented 6 years ago

I will not merge any new changes until i get the approval from all Team, so it will be in pending status until we agree all on this.