search

ivanvanderbyl / ember-spin-button

A button with an animated spinner as an Ember CLI addon
MIT License
7 stars 15 forks source link

Fixed animation #10

Closed IgorKvasn closed 8 years ago

IgorKvasn commented 8 years ago

Button animation should not start before spinner is actually shown. I guess pictures will make it more clear :)

Before: http://s12.postimg.org/h9exw4ril/spinner_button_before_fix.gif After: http://s12.postimg.org/b9r6sh6q5/spinner_button_after_fix.gif

I also fixed the tests runner (tests weren't running at all due to Ember-CLI problem)

ivanvanderbyl commented 8 years ago

Thanks for the contribution @IgorKvasn, just a few small changes required.

IgorKvasn commented 8 years ago

Hi, I pushed some new stuff, but I don't think it will be enough, though :( I am not sure if I understood your "breaking change" comment (please see my response).

btw. great addon :+1: