search

ivanvanderbyl / ember-spin-button

A button with an animated spinner as an Ember CLI addon
MIT License
7 stars 15 forks source link

"calling set on destroyed object" when action completes after component is destroyed #20

Open DuBistKomisch opened 8 years ago

DuBistKomisch commented 8 years ago

Hi Ivan waves across office

Same error message as https://github.com/ivanvanderbyl/ember-spin-button/issues/2 but I'm pretty sure it's caused by ember-spin-button, not internals, as I'm on 1.13 (soon to be 2).

I can cause it by pressing the button to run a long action, navigating away from the page, and then having the action complete.

I assume https://github.com/ivanvanderbyl/ember-spin-button/blob/master/app/components/spin-button.js#L35 needs some sort of guard to check this still exists.