Prevent default action on click handler

ivanvanderbyl / ember-spin-button

A button with an animated spinner as an Ember CLI addon

MIT License

7 stars 15 forks source link

Prevent default action on click handler #9

Closed digitalcora closed 9 years ago

digitalcora commented 9 years ago

Spin buttons currently don't prevent the default browser action in their click handler, resulting in unintended side effects – for example, spin buttons within forms causing the page to reload as the browser "submits" the form. This change makes {{#spin-button action=(action 'save')}} behave the same as <button {{action 'save'}}>.

digitalcora commented 8 years ago

Hey @ivanvanderbyl, thanks for merging this – any chance you could roll a new point release? I have a project that needs this fix, and right now I'm using a GitHub URL in package.json to get it.