Ember-cli upgrade - Githubissues

ivanvanderbyl / maximum-plaid

Template driven data visualisation for Ember

http://maximum-plaid.com/

MIT License

74 stars 9 forks source link

Ember-cli upgrade #7

Closed mike-north closed 8 years ago

mike-north commented 8 years ago

[x] Sublime text project, for easy ignore of ./tmp, ./node_modules, './bower_components`
[x] JSHint passing
[x] JSCS passing
[x] Tests passing
[x] Rely on shim addons instead of adding npm/power deps within this addon

mike-north commented 8 years ago

[x] Tests are failing on master, so next step is getting them passing

ivanvanderbyl commented 8 years ago

Nice work mate. So with D3 v3, I'm not totally convinced going back to that is a good idea. D3 v4 has much better APIs as well as d3-shape. Without d3 shape we'll need to do a lot of heavy lifting ourselves.

mike-north commented 8 years ago

@ivanvanderbyl I think we're good to go for fastboot, providing the following happens

[x] https://github.com/ivanvanderbyl/ember-cli-d3-shape/pull/11 is merged, a new release is cut and published
[x] https://github.com/ivanvanderbyl/ember-cli-d3-shape/issues/12 is addressed (nice to have)
[x] Then, merge this PR

mike-north commented 8 years ago

@ivanvanderbyl r?