Easily adjust top & bottom offsets of the indicator view

ivanvorobei / SPIndicator

Floating indicator, mimicrate to indicator which appear when silent mode switched. Can be present from top and bottom. Interactive with gesters.

https://opensource.ivanvorobei.io

MIT License

768 stars 48 forks source link

Easily adjust top & bottom offsets of the indicator view #2

Closed AngCosmin closed 3 years ago

AngCosmin commented 3 years ago

Hey 👋

Thanks for this amazing library. 🔥

Goal

The goal is to easily change the top and bottom offset. From my point of view, on iPhones <= 8, the indicator is too close to the status bar so therefore I implemented an easy way to adjust the offset of the indicator.

Checklist

[x] Testing in iOS, tvOS
[x] Installed correct via Swift Package Manager and Cocoapods

ivanvorobei commented 3 years ago

Thanks, good idea. How about create one property offset and use it value? We can add it if present from top and reduce it if present from bottom. And we have one value.

AngCosmin commented 3 years ago

Very good suggestion! I updated the PR. Thanks!

ivanvorobei commented 3 years ago

Last thing please, move property from layout to alert view. I can explain: layout object represent only internal sizes and spaces. Offset it global position, so better move it under Layout section in SPIndicatorView.

AngCosmin commented 3 years ago

Ok, done! 👍

ivanvorobei commented 3 years ago

Thanks! doing now new version