ivapylibs / puzzle_solver

1 stars 2 forks source link

Puzzle features rebuilt every comparison #39

Closed pv33 closed 10 months ago

pv33 commented 11 months ago

It looks like the matcher generates the feature vector every time two pieces are compared. That means an already compared piece will have its feature vector synthesized each time. Seems wasteful. The feature vector should be intrinsic to the actual puzzle piece and computed once per piece.

It is not clear why Yunzhi took this approach and makes little sense from a computational perspective, especially when dealing with visual information that can be not-cheap to process. Why was this done?

For longer term suitability of code, this part needs to be corrected. That will affect all of the matcher classes plus the puzzle template class. Oh man.

pv33 commented 11 months ago

Done, but now need to figure out how to update a puzzle piece information content during correspondence generation.

What of the board puzzle piece stored content should be updated? How does the board prior operate?

Status 10/17: Gonna have to leave for next time.