pv33
commented
3 weeks ago There is no functional difference at this point as long as nothing changes with the puzzle. Also the code has dropped passing of the centroid because it was confusing. There may need to be a centroid field too.
In the end though, the rLoc will be the current location and pcorner will be the original location when instantiated. All plotting will be done with rLoc and not with pcorner. When the piece is shifted, the change should be applied to rLoc and not to pcorner.
What will be needed is to percolate this to the data association part. What is it does not have access to rLoc but only to pcorner?
What is the difference between pcorner and rLoc??
It looks like rcoords has the coordinates in what?? Should be only relative to puzzle piece template size, not bigger image. To put in bigger image requires shifting them. But by what coordinate? pcorner or rLoc? Which should prevail?
Is pcorner the original instantiation? rLoc is the current one? does this permit backtracking to original detected piece location or to puzzle solution location? What is up?
check out todo comments in
piece.pyaround line 105. Looks like I commented on this a while back. It definitely needs to be resolved and then consistency maintained.