search

ivelum / djangoql

Advanced search language for Django
MIT License
1.02k stars 89 forks source link

Steps to bundle the completion #83

Open vkrizan opened 3 years ago

vkrizan commented 3 years ago

Hello,

The completion JS is bundled within the PyPi. Would it be possible to share the steps how to bundle it? We'd like to package it to RPM as well, to make it compatible.

Thank you.

stebunovd commented 3 years ago

Hi @vkrizan,

I'm not familiar with RPM packaging, so please let me know if the steps described below are not what you're looking for. Basically, to install or upgrade the JS completion package I do the following:

0) make sure that you have node installed and the latest version of Yarn v1 (also known as "yarn classic"). I'm currently using node v15. It may be compatible with other node versions, but I didn't check that; 1) run yarn in the repo root to install JS dependencies mentioned in package.json, including djangoql-completion; 2) run yarn build in the repo root to build the JS bundle using webpack. The resulting file is saved in djangoql/static/djangoql/js/ folder as specified in the Webpack configuration.

That's it. Does it work for you, or do you need anything else?

Thanks,

Denis

vkrizan commented 3 years ago

Thanks @stebunovd, that will do. Mostly we wanted to know how its build and what exactly is bundled where.

I'll look into it how to port it into the build process. There are some macros for Node.js build created. If you are curious you can check those out at https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/ Probably it could be an npm install kind of build, but I guess yarn is also available.

stebunovd commented 3 years ago

I suppose npm should also work, there’s nothing yarn-specific in this build