iveney / googletest

Automatically exported from code.google.com/p/googletest
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

gtest-config does not work with non-absolute prefix path #101

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. make install with a prefix which is not an absolute path (e.g.
containing /path/to/somewhere/libs/gtest/../../ins)
2. call gtest-config --version

What is the expected output? What do you see instead?
$ ./gtest-config --version
cd: 236: can't cd to
/path/to/somewhere/ins/bin//path/to/somewhere/libs/gtest/gtest-1.2.1
1.2.1

What version of the product are you using? On what operating system?
gtest 1.2.1 on linux

Please provide any additional information below.
I think in gtest-config.in the bindir should be converted into an absolute
path.
I attached a patch for this.

Original issue reported on code.google.com by housemaister on 23 Jan 2009 at 2:39

Attachments:

GoogleCodeExporter commented 9 years ago
Could you take a look, Chandler?  Thanks.

Original comment by zhanyong...@gmail.com on 26 Jan 2009 at 6:46

GoogleCodeExporter commented 9 years ago
This patch is fine. It's not a matter of relative vs. absolute paths, but a 
case of getting the hermetic path with no 
irregularities. The patch does that the right way. housemaister, is there a 
Reitveld issue? Not sure its necessary, 
this looks fine to submit as-is. I can submit it if you don't have time.

Original comment by chandl...@gmail.com on 27 Jan 2009 at 8:45

GoogleCodeExporter commented 9 years ago
I submitted a review issue: http://codereview.appspot.com/12517

Original comment by housemaister on 27 Jan 2009 at 9:20

GoogleCodeExporter commented 9 years ago
Thanks, guys.

Chandler, could you notify me when it's checked in such that I can propagate it 
to
our perforce branches?  Or you are welcome to propagate it yourself.

Original comment by zhanyong...@gmail.com on 27 Jan 2009 at 7:15

GoogleCodeExporter commented 9 years ago
We are phasing out autotools.

Original comment by w...@google.com on 23 Dec 2009 at 7:02