search

iveney / googletest

Automatically exported from code.google.com/p/googletest
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Make sure internal macros end with _ #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Macros don't respect namespaces, so it is sometimes hard for a user to tell
whether a Google Test macro is public or not.

To reduce the likelihood of a user accidentally depend on Google Test's
internal implementation, we should name all internal macros *_ (i.e. ending
with an underscore).

Original issue reported on code.google.com by shiq...@gmail.com on 2 Jul 2008 at 7:26

GoogleCodeExporter commented 9 years ago

Original comment by markus.h...@gmail.com on 30 Sep 2008 at 10:57

GoogleCodeExporter commented 9 years ago 
Markus did this in trunk.  I need to scan the code to see if there are any more 
macros that should be converted.

Original comment by shiq...@gmail.com on 12 Oct 2008 at 3:23

GoogleCodeExporter commented 9 years ago 
There are some macros still needing the fix.  I've done it in a pending CL 
which has 
been reviewed by Vlad and will be checked in on Monday.

Original comment by zhanyong...@gmail.com on 22 Feb 2009 at 5:45