iveney / googletest

Automatically exported from code.google.com/p/googletest
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Incorrect output format for MSVC #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a failing test
2. Run the test in Microsoft Visual Studio

What is the expected output?
unittest.cc(107): error: Value of: false
  Actual: false
Expected: true

What do you see instead?
unittest.cc:107: Failure
Value of: GTEST_IS_NULL_LITERAL(1)
  Actual: false
Expected: true

What version of the product are you using? On what operating system?
1.0.0
Windows
Visual Studio 2005

Please provide any additional information below.
Currently the PrettyUnitTestResultPrinter prints failures in this 
format: "FILE:LINE: Failure", while MSVC expects this format: 
"FILE(LINE): error: ..."!

I've created a patch which uses the correct format iff _MSC_VER defined.

Original issue reported on code.google.com by Balazs....@gmail.com on 9 Jul 2008 at 2:50

Attachments:

GoogleCodeExporter commented 9 years ago
Code review: http://codereview.appspot.com/2582

Original comment by shiq...@gmail.com on 16 Jul 2008 at 11:19

GoogleCodeExporter commented 9 years ago
I think you can close this issue as it works fine with r66.
However, we could improve it with displaying actual and expected values in such 
format that is displayable by VS..

Original comment by Balazs....@gmail.com on 24 Jul 2008 at 2:13

GoogleCodeExporter commented 9 years ago

Original comment by shiq...@gmail.com on 31 Jul 2008 at 6:37