Fixed URL query building - Githubissues

iver-wharf / wharf-api

Wharf backend written in Go

MIT License

1 stars 0 forks source link

Fixed URL query building #157

Closed applejag closed 2 years ago

applejag commented 2 years ago

Summary

Changed the trigger URL building to use proper URL building.

Motivation

Less prone to glitches and security vulnerabilities.

For example, if the engine URL before had a fragment, then it ruined the URL building:

http://jenkins.local/trigger#foo
// got turned into:
http://jenkins.local/trigger#foo?token=abc&stage=def&environment=etc

While now it correctly edits the correct part:

http://jenkins.local/trigger#foo
// now gets turned into:
http://jenkins.local/trigger?token=abc&stage=def&environment=etc#foo