Closed applejag closed 2 years ago
Oh but wait, the foreign keys are messed up...
Example:
$ \dS token
Table "public.token"
Column | Type | Collation | Nullable | Default
------------+--------------------------+-----------+----------+-----------------------------------------
created_at | timestamp with time zone | | |
updated_at | timestamp with time zone | | |
token_id | bigint | | not null | nextval('token_token_id_seq'::regclass)
value | character varying(500) | | not null |
user_name | character varying(500) | | not null | ''::character varying
Indexes:
"token_pkey" PRIMARY KEY, btree (token_id)
Foreign-key constraints:
"fk_branch_token" FOREIGN KEY (token_id) REFERENCES branch(branch_id) ON UPDATE RESTRICT ON DELETE RESTRICT
"fk_project_token" FOREIGN KEY (token_id) REFERENCES project(project_id) ON UPDATE RESTRICT ON DELETE RESTRICT
"fk_provider_token" FOREIGN KEY (token_id) REFERENCES provider(provider_id) ON UPDATE RESTRICT ON DELETE RESTRICT
Perhaps we need to tackle #146 first anyway
Oh but wait, the foreign keys are messed up...
Example:
$ \dS token Table "public.token" Column | Type | Collation | Nullable | Default ------------+--------------------------+-----------+----------+----------------------------------------- created_at | timestamp with time zone | | | updated_at | timestamp with time zone | | | token_id | bigint | | not null | nextval('token_token_id_seq'::regclass) value | character varying(500) | | not null | user_name | character varying(500) | | not null | ''::character varying Indexes: "token_pkey" PRIMARY KEY, btree (token_id) Foreign-key constraints: "fk_branch_token" FOREIGN KEY (token_id) REFERENCES branch(branch_id) ON UPDATE RESTRICT ON DELETE RESTRICT "fk_project_token" FOREIGN KEY (token_id) REFERENCES project(project_id) ON UPDATE RESTRICT ON DELETE RESTRICT "fk_provider_token" FOREIGN KEY (token_id) REFERENCES provider(provider_id) ON UPDATE RESTRICT ON DELETE RESTRICT
Perhaps we need to tackle #146 first anyway
I think it would be good to tackle #146 first, yeah. Since the models are split up it could even be possible to fix it without really having to do anything with the non-database models. 🤔
I think it would be good to tackle #146 first, yeah. Since the models are split up it could even be possible to fix it without really having to do anything with the non-database models. thinking
I got it to work via #163.
I do not look forward to fixing #146, as it requires some DB remodelling, migrations, and adding backward compatibility to keep the request and response REST models intact. We need to do that at some point, but not right now. I want to focus on wharf-cmd now.
(WIP)
tag to today's date inCHANGELOG.md
release
label to this PRChanges
Actions after merge
Follow the step-by-step guide found here: https://iver-wharf.github.io/#/development/releasing-a-new-version?id=merging-a-release-pr