Fixed token always getting redacted - Githubissues

iver-wharf / wharf-api

Wharf backend written in Go

MIT License

1 stars 0 forks source link

Fixed token always getting redacted #166

Closed applejag closed 2 years ago

applejag commented 2 years ago

[x] I've added a new note in the CHANGELOG.md file, according to docs: https://iver-wharf.github.io/#/development/changelogs/writing-changelogs

Summary

Fixed actual trigger URL used also getting censored

Motivation

Apparently you cannot make a copy by doing &(*u).

Doesn't matter much as we can just use the dereferenced variant.

Also changed the redacted text as ***** gets logged as %2A%2A%2A%2A%2A, while ~redacted~ isn't escaped.

This has been deployed to our canary environment and proven to work.