wharf-core logging & configs

iver-wharf / wharf-provider-gitlab

Import Wharf projects from GitLab repositories

MIT License

2 stars 0 forks source link

wharf-core logging & configs #23

Closed applejag closed 3 years ago

applejag commented 3 years ago

[x] I've added a new note in the CHANGELOG.md file, according to docs: https://iver-wharf.github.io/#/development/changelogs/writing-changelogs

Summary

Swaggo/swag v1.7.1, replacing dependency on alecthomas/template with stdlib text/template.
Added logging via wharf-core/pkg/logger, instead of via fmt.Println
Added loading configuration via wharf-core/pkg/config, thus allowing both config file and environment variables

Motivation

Keeping the projects up to date with our own packages.

applejag commented 3 years ago

@fredx30 This is doing way more than the description lets on which is dangerous. If this was only a package update i would expect only dockerfile, gosum and gomod to change. Code quality seems good. have not checked for intent as per agreement for the logging project.

Oh I thought it was enough with the

wharf-core logging.

wharf-core configs.

I'll update it so it more describes what's up

applejag commented 3 years ago

@fredx30 have not checked for intent as per agreement for the logging project.

That verbal agreement was on the problem/error responses. What kind of declaration of intent would you like to see?