iver-wharf / wharf-provider-gitlab

Import Wharf projects from GitLab repositories
MIT License
2 stars 0 forks source link

Added docs to types #24

Closed applejag closed 3 years ago

applejag commented 3 years ago

Summary

Motivation

To begone with all linting issues.

Remaining linting issues:

$ npm run lint-go
testdoubles/wharfclientapifetcher_mock.go
  (15, 37)  https://revive.run/r#var-naming  method GetTokenById should be GetTokenByID
  (34, 37)  https://revive.run/r#var-naming  method GetProviderById should be GetProviderByID

trigger.go
  (25, 1)  https://revive.run/r#exported  exported function RunRepositoryUpdateTrigger should have comment or be unexported

 ✖ 3 problems (0 errors) (3 warnings)

The wharfclientapifetcher_mock.go ones are out of our control, as those names actually comes from the wharfapi package inside the wharf-api-client-go repo. Update for that is on its way, but until then this is left as-is.

The trigger.go one is about to be removed in #23, so I'm leaving it out in this one.