Changed to use wharf-core/pkg/cacertutil instead of internal/httputils - Githubissues

iver-wharf / wharf-provider-gitlab

Import Wharf projects from GitLab repositories

MIT License

2 stars 0 forks source link

Changed to use wharf-core/pkg/cacertutil instead of internal/httputils #25

Closed Alexamakans closed 3 years ago

Alexamakans commented 3 years ago

[x] I've added a new note in the CHANGELOG.md file, according to docs: https://iver-wharf.github.io/#/development/changelogs/writing-changelogs
[x] Wait for wharf-core release with change from https://github.com/iver-wharf/wharf-core/pull/27.

Summary

Changed to use wharf-core/pkg/cacertutil instead of internal/httputils
Deleted internal/httputils

Motivation

Copies of the internal/httputils package exists in multiple repos: wharf-api, wharf-provider-github, wharf-provider-gitlab, and wharf-provider-azuredevops.

Moving it to wharf-core reduces code duplication, and makes changing the code simpler.

PR & Issue

Depends on pull request: https://github.com/iver-wharf/wharf-core/pull/27 Related issue: https://github.com/iver-wharf/wharf-core/issues/26