Closed Alexamakans closed 2 years ago
Build is failing and cross linking with the other PRs in the change is missing see ex. https://github.com/iver-wharf/wharf-api-client-go/pull/21#issuecomment-968621369 and/or https://github.com/iver-wharf/wharf-provider-github/pull/35
Build is failing and cross linking with the other PRs in the change is missing see ex. iver-wharf/wharf-api-client-go#21 (comment) and/or iver-wharf/wharf-provider-github#35
Reverted checklist to specify that this PR depends on
again. The changes in the other providers shouldn't require that though.
Is the cross linking I've done now satisfactory, or do you have some other suggestion on how to do it?
Marking this PR as draft again until iver-wharf/wharf-api-client-go#21 has been released 👍🏻
This PR has been made obsolete by #43
[x] I've added a new note in the
CHANGELOG.md
file, according to docs: https://iver-wharf.github.io/#/development/changelogs/writing-changelogs[x] Wait for new release of wharf-api, with iver-wharf/wharf-api#82
[x] Wait for new release of wharf-api-client-go, with iver-wharf/wharf-api-client-go#21.
Summary
Removed
UploadURL
field from theImport
struct. Removed any reference towharfapi.Provider.UploadURL
.Motivation
These fields did not provide any functionality and were thus effectively just bloat.
Required change to be compatible with iver-wharf/wharf-api-client-go#21
Part of inter-repo change, together with:
-- Closes #27