iver-wharf / wharf-provider-gitlab

Import Wharf projects from GitLab repositories
MIT License
2 stars 0 forks source link

Removed UploadURL references #30

Closed Alexamakans closed 2 years ago

Alexamakans commented 3 years ago

Summary

Removed UploadURL field from the Import struct. Removed any reference to wharfapi.Provider.UploadURL.

Motivation

These fields did not provide any functionality and were thus effectively just bloat.

Required change to be compatible with iver-wharf/wharf-api-client-go#21

Part of inter-repo change, together with:

-- Closes #27

fredx30 commented 3 years ago

Build is failing and cross linking with the other PRs in the change is missing see ex. https://github.com/iver-wharf/wharf-api-client-go/pull/21#issuecomment-968621369 and/or https://github.com/iver-wharf/wharf-provider-github/pull/35

Alexamakans commented 3 years ago

Build is failing and cross linking with the other PRs in the change is missing see ex. iver-wharf/wharf-api-client-go#21 (comment) and/or iver-wharf/wharf-provider-github#35

Reverted checklist to specify that this PR depends on

again. The changes in the other providers shouldn't require that though.

Is the cross linking I've done now satisfactory, or do you have some other suggestion on how to do it?

Marking this PR as draft again until iver-wharf/wharf-api-client-go#21 has been released 👍🏻

Alexamakans commented 2 years ago

This PR has been made obsolete by #43