iveykun / rubyhoshino

ruby hoshino's church
0 stars 0 forks source link

Side scrolling works intermittently #5

Open zeyuanfu opened 1 year ago

zeyuanfu commented 1 year ago

After collapsing the white sidebar, scrolling left and right (using shift + mousewheelup/mousewheeldown) does not always cause the image sequence to shift left or right. Instead, most of the time, scrolling right does nothing and scrolling left re-expands the white sidebar.

Environment

Windows 10 22H2 Chrome 114.0.5735.110

Expected behavior

I am able to scroll left or right in the image sequence

Actual behavior

I am unable to scroll left or right in the image sequence

iveykun commented 1 year ago

I had previously added a scrolling sideways / dragging mouse / touch feature, but I had trouble with the carousel resuming when you were done scrolling. It also resulted in a bug on PC where if you spam the drag it would bug out and infinite carousel (and never pause when you touch the screen)

Will work on this once I implement more important features

iveykun commented 1 year ago

proposed potential slns:

  1. autoscroll pauses when overlay is up ; user can then drag the images, click on them, and manually scroll using mouse wheel or shift+scroll

  2. autoscroll pauses when mouse is over the middle area (the wrapper): will resume as it leaves the wrapper. Clicking image links to src.

  3. autoscroll pauses when mouse clicks on an image (either to start draging or else); I will then add a small button to link to the source of the image

zeyuanfu commented 1 year ago

both solutions 1 and 2 sound good, however:

soln 1: the overlay veils the images, I would like to see the images scrolling without being covered by anything

soln 2: the middle area occupies the large majority of the webpage's area so the region in which autoscrolling is enabled would be very small

iveykun commented 1 year ago

so.. 3? time to pepega center buttons i hate frontend dev

zeyuanfu commented 1 year ago

3 seems like the least desirable solution to me since clicking on the image should open the source