search

iviasensio / PLSmartPivot

PL Smart Pivot Report for Qlik Sense
MIT License
19 stars 19 forks source link

FIxes on layout issues #3

Closed pavelpykhtin closed 7 years ago

pavelpykhtin commented 8 years ago

Hi!

Thank you for your extension and it's great features. We are using it in out project and faced with some layout issues:

  1. Column headers are not aligned with cells
  2. Some of row headers are higher than others which leads to misaligning with cells in rows
  3. Empty rows (where there is no data in any cell) are collapsed while row headers are shown with initial height

I've added fixes on this issues and also translated styles to less (this significantly simplifies maintenance). Main fixes are:

  1. Applied box-sizing: border-box to simplify handling of cell's paddings
  2. Explicitly specified line-height for row headers and cells and added 'dummy' content to guarantee same row height and alignment for row headers and datarows

It would be nice if you merged these changes!

Best regards.

iviasensio commented 7 years ago

Thanks a lot Pavel for your contribution

Sorrry for the extremely large delay in answering. I do not use to have time to invest in extensions, as my core activity is just presales. Currently I've fixed an issue that makes fail applying the external look&feel template with version 3.2, I'll take profit from this opportunity to release the new fixes including your contributions.

Regards