ivision-research / banjo

Android Dex disassembler and Binary Ninja plugin
MIT License
52 stars 6 forks source link

numbers don't behave well in binja #28

Closed austin-ralls-cs closed 3 months ago

austin-ralls-cs commented 4 years ago

Trying to change them from one format to another breaks them completely. I suspect that this has something to do with IntegerToken, which used to be marked as internal-only in the docs but isn't any more.

TODO investigate changes to https://api.binary.ninja/binaryninja.function.InstructionTextToken.html#binaryninja.function.InstructionTextToken to figure out how to fix this.

KyleMiles commented 3 years ago

You need to populate the value field of integer tokens.