search

ivision-research / banjo

Android Dex disassembler and Binary Ninja plugin
MIT License
52 stars 6 forks source link

AccessFlags tests not tested #6

Closed austin-ralls-cs closed 4 years ago

austin-ralls-cs commented 4 years ago

I wrote some tests before I fully figured out how AccessFlags should be rendered as strings. I deleted the obviously wrong tests, but due to #5 I haven't actually ran the rest since writing the string functions.

They should either be deleted or finished.

https://github.com/CarveSystems/banjo/blob/bd07db6c3a8de9b4eff56d381c581909b0ea2b05/android/dex.py#L418

Depends on #5.

austin-ralls-cs commented 4 years ago

Fixed in https://github.com/CarveSystems/banjo/commit/20639aecf4de68e9f4881655f6fafa9b2e1450c2 by adding more tests.