search

ivmarkov / rust-esp32-std-demo

Rust on ESP32 STD demo app. A demo STD binary crate for the ESP32[XX] and ESP-IDF, which connects to WiFi, Ethernet, drives a small HTTP server and draws on a LED screen.
Apache License 2.0
785 stars 105 forks source link

partitions.csv not being picked up. #116

Open axos88 opened 1 year ago

axos88 commented 1 year ago

sdkconfig.defaults is missing:

CONFIG_PARTITION_TABLE_SINGLE_APP=
CONFIG_PARTITION_TABLE_CUSTOM=y

But even then the build is looking for the partitions.csv in the wrong place

axos88 commented 1 year ago

I needed to add the following as well:

CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="../../../../../../partitions.csv"
pyaillet commented 1 year ago

espflash documentation here states that you can either pass this as a parameter to the command or add a configuration in Cargo.toml

axos88 commented 1 year ago

The problem is that the example project has this file in the root directory, but it's not actually used, which is misleading. Either it would need to be added to the README.md, or these config options need to be added, so a newcomer is not confused by their edits to the partition table file not being picked up.

pyaillet commented 1 year ago

Yes, that's why I proposed a PR #117 adding the configuration to Cargo.toml :)

axos88 commented 1 year ago

Sorry, I did not see that!