Open sirhcel opened 9 months ago
This is only a partial solution, as this way you'll get the custom partition from rust-esp32-std-demo
BUT the bottloader from espflash
.
I think it should be all or nothing - either you get both from rust-esp32-std-demo
, or none.
I think either the cargo-metadata
approach (assuming cargo espflash
is intelligent enough to still grab the bootloader in addition to the partitions table passed via cargo-metadata), or the sdkconfig.defaults
one is therefore preferred.
With what I've learned from https://github.com/esp-rs/esp-idf-sys/pull/264 and https://github.com/esp-rs/espflash/issues/505#issuecomment-1835665681, I see that there is way more to it.
What yould you prefer? Closing this PR or updating it, when espflash
/cargo-espflash
get support for using partition and boolader from https://github.com/esp-rs/esp-idf-sys/pull/264?
What about making the partition table explicit and not relying on lucky defaults from
espflash
? What about integrating this together with #117 which works like a charm for me when usingcargo espflash
.