search

ivmarkov / rust-esp32-std-demo

Rust on ESP32 STD demo app. A demo STD binary crate for the ESP32[XX] and ESP-IDF, which connects to WiFi, Ethernet, drives a small HTTP server and draws on a LED screen.
Apache License 2.0
785 stars 105 forks source link

Use partition table from this repo with espflash #156

Open sirhcel opened 9 months ago

sirhcel commented 9 months ago

What about making the partition table explicit and not relying on lucky defaults from espflash? What about integrating this together with #117 which works like a charm for me when using cargo espflash.

ivmarkov commented 9 months ago

This is only a partial solution, as this way you'll get the custom partition from rust-esp32-std-demo BUT the bottloader from espflash.

I think it should be all or nothing - either you get both from rust-esp32-std-demo, or none.

ivmarkov commented 9 months ago

I think either the cargo-metadata approach (assuming cargo espflash is intelligent enough to still grab the bootloader in addition to the partitions table passed via cargo-metadata), or the sdkconfig.defaults one is therefore preferred.

sirhcel commented 8 months ago

With what I've learned from https://github.com/esp-rs/esp-idf-sys/pull/264 and https://github.com/esp-rs/espflash/issues/505#issuecomment-1835665681, I see that there is way more to it.

What yould you prefer? Closing this PR or updating it, when espflash/cargo-espflash get support for using partition and boolader from https://github.com/esp-rs/esp-idf-sys/pull/264?