Couple of small fixes for windows build

ivmarkov / rust-esp32-std-demo

Rust on ESP32 STD demo app. A demo STD binary crate for the ESP32[XX] and ESP-IDF, which connects to WiFi, Ethernet, drives a small HTTP server and draws on a LED screen.

Apache License 2.0

785 stars 105 forks source link

Couple of small fixes for windows build #37

Closed Hecatron closed 2 years ago

Hecatron commented 2 years ago

Hi, I've added a couple of small fixes

The one involving use std::result::Result::Ok; might be related to the latest toolchain I'm not sure but seems to be a requirement for the build to work

The rust-toolchain.toml file is just a convenience to default the toolchain to use as "esp"

ivmarkov commented 2 years ago

See comment here: https://github.com/ivmarkov/embuild/pull/26

I do not plan on merging this. Rather, let's wait for the next Rust nightly.

As for putting the rust-toolchain thing, I'm a bit against it. It will be an inconvenience for those folks, who would prefer to use the nightly compiler instead.

Hecatron commented 2 years ago

Ok no problem. Ill close this down in that case. I wasn't aware that the esp targets were going to show up under nightly any time soon (I don't think they're in just yet)