ivmartel / dwv-jqui

Medical image viewer based on DWV (DICOM Web Viewer) and jQuery UI.
https://ivmartel.github.io/dwv-jqui/
GNU General Public License v3.0
18 stars 18 forks source link

download function raises Uncaught TypeError: t.getX is not a function #70

Closed tommyJin closed 2 years ago

tommyJin commented 2 years ago

Hi, happy new year, When I draw something and try to download the state.json file, the error occurs. I've tried the v0.6.0 and v0.7.0-beta. But I found the live demo v0.5.1 is ok with the download function[https://ivmartel.github.io/dwv-jqui/demo/stable/index.html]

Uncaught TypeError: t.getX is not a function
    at A.io.State.toJSON (dwv.min.js:3)
    at A.App.getState (dwv.min.js:3)
    at HTMLAnchorElement.toggleSaveState.onclick (appgui.js:155)

And I traced with the error and found it is located in the file state.js on line 52 position: [position.getX(), position.getY(), position.getZ()], of the dwv project state.js#L52

Thx.

tommyJin commented 2 years ago

Could u pls update the npm repo version? I redo npm install & npm run dev, and the question remains. In the package.json, the dependency of dwv version is "dwv": "0.30.7" Thx.

ivmartel commented 2 years ago

I'll check if everything is ok and then create a release.

tommyJin commented 2 years ago

Cheers!

ivmartel commented 2 years ago

Just released dwv 0.30.8, check demo/trunk/index.html for an updated dwv-jqui.

tommyJin commented 2 years ago

Brilliant job!