search

ivmartel / dwv

DICOM Web Viewer: open source zero footprint medical image library.
https://ivmartel.github.io/dwv/
GNU General Public License v3.0
1.68k stars 593 forks source link

The response of windowlevel is very slow #34

Closed notox closed 11 years ago

notox commented 11 years ago

If I change windowlevel several times, the viewer won't immediately reponse. I think the experience could be improved.

ivmartel commented 11 years ago

Hi, thanks for your feedback. You are right, on some platforms/browsers, the w/l can be quite slow. The bigger the image, the slower too. What is your configuration?

notox commented 11 years ago

I tested with the newest Chrome and Firefox on Win7. Which configuration will be fast?

jap1968 commented 11 years ago

What do you consider a good response time? I am getting times in the range of about 400 ms for a rather big image (~5 MM Pixels) on my old desktop computer. I find these values acceptable.

notox commented 11 years ago

I test the response again. Chrome is faster than Firefox. The response on Chrome is fast. When I stop moving the mouse, the dicom viewer response immediately. However, the response on Firefox will take about 2-3 seconds.

I think we can improve the response speed while mouse moving instead of mouse stopping on Chrome. When I change the windowlevel, I hope that I can adjust my moving by watching the response without mouse stopping.

Thank you for you quick feedback:)

ivmartel commented 11 years ago

I agree, Firefox is a bit slow... I put some notes on the different platforms on this wiki page: https://github.com/ivmartel/dwv/wiki/Platform-support

notox commented 11 years ago

I found that the response would be fast when I uncomment the function updatePlot. This function spends a lot of time. It will take about 2-3 seconds to change the windowlevel one times by Chrome. I found updatePlot spent a lot of CPU time by Chrome timeline. So I uncomment the function. After that, it only need 230ms to finish the change.

ivmartel commented 11 years ago

Good point. I disabled the update of the plot when it is not displayed and I can see the difference under Firefox. I need to better use flot or find a faster library! A small question so that we have the same timings, how do you measure the display time?

notox commented 11 years ago

Chrome's developer tools(Ctrl+Shift+I). Switch to the timeline tab and click the 'Record' button. You can watch the display time by this method.

ivmartel commented 11 years ago

I hope this new release (v0.4) goes in the good direction...