ivmfnal / metacat

Metadata Catalog
BSD 3-Clause "New" or "Revised" License
4 stars 5 forks source link

Request: recognize strings so you don't need to use quotes #4

Closed hschellman closed 1 year ago

hschellman commented 1 year ago

metacat query "files where creator='calcuttj' limit 3"

just be creator=calcuttj? I think you need to do something like if first character != a number or a boolean, assume it's a string.

ivmfnal commented 1 year ago

so what if the user wants to represent a string "3" ? or what if the string contains a space ?

The above examples show that while this suggestion marginally reduces the amount of typing to enter a query, it does not completely eliminate the need to use quotes and makes the lexical analysis harder and in fact does not improve readability of the query

hschellman commented 1 year ago

I would say if you want “3” you say “3”.

People are going to be moving over from sam and having to use 2 types of quotes for basic queries is going to cause some woe.

I will presume that samweb somehow knows the types for various values and makes an assumption. Ie, if creator is a string, it assumes the = is a string. THat might be a better way of handling this.

THat of course assumes that either the client or the server knows all of these types but I believe they are set when you declare a new value.

On Sep 26, 2022, at 7:48 AM, Igor Mandrichenko @.**@.>> wrote:

[This email originated from outside of OSU. Use caution with links and attachments.]

so what if the user wants to represent a string "3" ? or what if the string contains a space ?

The above examples show that while this suggestion marginally reduces the amount of typing to enter a query, it does not completely eliminate the need to use quotes and makes the lexical analysis harder and in fact does not improve readability of the query

— Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fivmfnal%2Fmetacat%2Fissues%2F4%23issuecomment-1258155216&data=05%7C01%7Cheidi.schellman%40oregonstate.edu%7C815f7a12d1284227ef2f08da9fce32c6%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C637998005203591603%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2Fdsw3djRuCI1ntNwFsxVckAv4NpFA0yzepg%2BwLYSed4%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIA37DJXRXIBVEY5XWXDVCDWAGZUNANCNFSM6AAAAAAQV3FZ4Q&data=05%7C01%7Cheidi.schellman%40oregonstate.edu%7C815f7a12d1284227ef2f08da9fce32c6%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C637998005203591603%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=zlY26MPPX621P4YtUscsqk0wUNjfI4vLvN5SeFmRawY%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

ivmfnal commented 1 year ago

done