Closed ivmfnal closed 1 year ago
What metadata category.name should be used for process id ? Possibilities:
Hi, if this was originally a sam dimension, not a parameter, I suggest it goes in core. I'm leaning towards
dimensions all got to core. parameters (with dots) stay the same.
Dimensions do not go to core. They go to the same category as they are in dimensions.
In SAM, process_id is not in dimensions. It is a column in data_files table. So it is logical to put it in core.
We have a chance to rename fields to better reflect their meaning and/or to organize them into categories. That is why I suggested some options for process_id:
I added process_id as core.process_id for now. We can change that if needed
Thanks, interestingly for dd it is a hash not a number as far as I can tell so format may be an issue. I’m putting worker_ID there or maybe I should put the batch jobID?
On Jan 18, 2023, at 10:48 AM, Igor Mandrichenko @.**@.>> wrote:
[This email originated from outside of OSU. Use caution with links and attachments.]
I added process_id as core.process_id for now. We can change that if needed
— Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fivmfnal%2Fmetacat%2Fissues%2F5%23issuecomment-1387572023&data=05%7C01%7Cheidi.schellman%40oregonstate.edu%7C5c8989145d1a476488fb08daf9848bd0%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C638096644922172936%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=b%2FKHvJOwutFMmJb7IQDt2EirKDpSevdNktKnFJNoTLI%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIA37DKCN3UH7ANHMPCEPOTWTA3GVANCNFSM6AAAAAAQWEJOHQ&data=05%7C01%7Cheidi.schellman%40oregonstate.edu%7C5c8989145d1a476488fb08daf9848bd0%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C638096644922172936%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RPZZA3nityzt%2FXLIyPvw5aM8Wf6xijILnzdMISkfR5s%3D&reserved=0. You are receiving this because you commented.Message ID: @.***>
DD worker ID is a string. It can be auto-generated by DD client (and currently it is a shortened UUID), or it can be assigned by the user.
Currently, process_id is not imported from SAM to MetaCat, but when it is, it can be converted to either a string or it can be stored as integer. It is up to DUNE to decide how they want this SAM attribute to be represented in MetaCat.
Is there a reason for the dd worker id to be a string? There was something nice about seeing the integers increase in sam as they were assigned. Not a big deal but worth a thought.
On Jan 18, 2023, at 12:21 PM, Igor Mandrichenko @.**@.>> wrote:
[This email originated from outside of OSU. Use caution with links and attachments.]
DD worker ID is a string. It can be auto-generated by DD client (and currently it is a shortened UUID), or it can be assigned by the user.
Currently, process_id is not imported from SAM to MetaCat, but when it is, it can be converted to either a string or it can be stored as integer. It is up to DUNE to decide how they want this SAM attribute to be represented in MetaCat.
— Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fivmfnal%2Fmetacat%2Fissues%2F5%23issuecomment-1387728890&data=05%7C01%7Cheidi.schellman%40oregonstate.edu%7C3a73d3fe822d4ee3105e08daf9918c8d%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C638096700768871682%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TxsuNs3hMlb69d1uMplFZaSohIAUisFN510CGhcmnyQ%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIA37DLSYMLVVC4R2WIEOETWTBGDVANCNFSM6AAAAAAQWEJOHQ&data=05%7C01%7Cheidi.schellman%40oregonstate.edu%7C3a73d3fe822d4ee3105e08daf9918c8d%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C638096700768871682%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PFuKrEz48dPMrzEYuCl7lv3qJNHy2eNFOfl1jD4I9zc%3D&reserved=0. You are receiving this because you commented.Message ID: @.***>
We can add generation of numeric, monotonically increasing worker id as a new DD function. This would be in addition to the existing UUID-based generation. The worker_id will still be string, but this way it can be a string which looks like an integer.
Is this what you want ?
Here is a caveat though. If we use multiple instances of DD, then we may need to come up with a way for the DD instances to generate non-overlapping sets of numeric worker ids.
That’s a good point. But then we need to record the instance we were talking to somehow.
On Jan 18, 2023, at 1:00 PM, Igor Mandrichenko @.**@.>> wrote:
[This email originated from outside of OSU. Use caution with links and attachments.]
Here is a caveat though. If we use multiple instances of DD, then we may need to come up with a way for the DD instances to generate non-overlapping sets of numeric worker ids.
— Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fivmfnal%2Fmetacat%2Fissues%2F5%23issuecomment-1396081496&data=05%7C01%7Cheidi.schellman%40oregonstate.edu%7Cfefbf34a1822459accfb08daf99719c9%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C638096724615782767%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=78AzGsSrevZT%2F%2B2yy7EM83jIVuczpN18faCFrbwdsAE%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIA37DNYA64XWFID67PNBKTWTBKYVANCNFSM6AAAAAAQWEJOHQ&data=05%7C01%7Cheidi.schellman%40oregonstate.edu%7Cfefbf34a1822459accfb08daf99719c9%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C638096724615782767%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=akH6nXuZUsYbyO4Wr7QZ0tSqqnUBebUsLlRl4Wr8Z%2FU%3D&reserved=0. You are receiving this because you commented.Message ID: @.***>
Lemme think about it. Seems a bit bad to have 2 different things.
On Jan 18, 2023, at 12:57 PM, Igor Mandrichenko @.**@.>> wrote:
[This email originated from outside of OSU. Use caution with links and attachments.]
We can add generation of numeric, monotonically increasing worker id as a new DD function. This would be in addition to the existing UUID-based generation. The worker_id will still be string, but this way it can be a string which looks like an integer.
Is this what you want ?
— Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fivmfnal%2Fmetacat%2Fissues%2F5%23issuecomment-1396077169&data=05%7C01%7Cheidi.schellman%40oregonstate.edu%7Ce86195be19eb459b14ee08daf9969916%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C638096722454802804%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tR8RjzVPvOmnpH%2FrLMwYvrX7ig78J6Dw3kbE7Y7n1Yc%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIA37DKTI2Y42YO2X5WFEDTWTBKLFANCNFSM6AAAAAAQWEJOHQ&data=05%7C01%7Cheidi.schellman%40oregonstate.edu%7Ce86195be19eb459b14ee08daf9969916%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C638096722454802804%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=s0fLg6qLN5QP9XNrEfF5OixGJyn5wj1ldpDgGn7NbjI%3D&reserved=0. You are receiving this because you commented.Message ID: @.***>
SAM file np04_raw_run010425_0090_dl12_reco1_28404162_0_20220121T051020Z_reco2_52848725_0_20220217T110748Z.root:
Converted to MetaCat: https://metacat.fnal.gov:9443/dune_meta_demo/app/gui/show_file?show_form=yes&namespace=&name=&did=default%3Anp04_raw_run010425_0090_dl12_reco1_28404162_0_20220121T051020Z_reco2_52848725_0_20220217T110748Z.root&fid=
What is missing: