search

ivnsch / SwiftCharts

Easy to use and highly customizable charts library for iOS
Apache License 2.0
2.53k stars 410 forks source link

ChartPointsScatterCrossesLayer does not allow a change of colour #298

Closed KaisEbraheem closed 6 years ago

KaisEbraheem commented 7 years ago

I have tried to change the colour for cross point type to anything but black. It always draws crosses in black. Any idea if this is a bug. Thanks

ivnsch commented 7 years ago

It should be customizable - the passed fill color is used as stroke color. See https://github.com/i-schuetz/SwiftCharts/blob/master/SwiftCharts/Layers/ChartPointsScatterLayer.swift#L227

Please ensure you are passing correctly the color.

KaisEbraheem commented 7 years ago

Thanks for your prompt feedback. Indeed I tried just that. The itemFillColor works fine for circle, square, triangle, except for cross, where the itemFillCollor is supposed to be used for the context's strokColor, but it doesn't. Strangely enough, I have even hard-coded the line: context.setStrokeColor(itemFillColor.cgColor) to context.setStrokeColor (UIColor.red.cgColor) and still crosses are painted black.

I guess, there is an issue here.

Regards, Kais

On Sun, Sep 17, 2017 at 7:15 PM, Ivan Schütz notifications@github.com wrote:

It should be customizable - the passed fill color is used as stroke color. See https://github.com/i-schuetz/SwiftCharts/blob/master/ SwiftCharts/Layers/ChartPointsScatterLayer.swift#L227

Please ensure you are passing correctly the color.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/i-schuetz/SwiftCharts/issues/298#issuecomment-330100888, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAOOj98_zGX0tB3NZac8C8xOlMw2j9Nks5sjagCgaJpZM4PaAnL .

ivnsch commented 7 years ago

You will have to debug this, since I don't have time (sorry). It shouldn't be difficult to figure by looking in the scatter layer. If there's a bug then a pull request is welcome.