Some issues in Swift 5 conversion!!

ivnsch / SwiftCharts

Easy to use and highly customizable charts library for iOS

Apache License 2.0

2.53k stars 410 forks source link

Some issues in Swift 5 conversion!! #383

Closed roozbehg closed 5 years ago

roozbehg commented 5 years ago

it seems hashValue is deprecated in Swift 5. is there any plan for Swift 5 conversion?

ivnsch commented 5 years ago

I'll look into this in a few days. If anyone wants to do it, feel free to submit a PR.

roozbehg commented 5 years ago

thank you Ivan!

bmalbuck commented 5 years ago

@i-schuetz @roozbehg Take a look at my Pull Request. I implemented hash(into hasher: inout Hasher)

bmalbuck commented 5 years ago

I fixed a lot of warnings in addition to Hashable. Also added a new target for a universal fat binary including a build phase script to strip architecture.

roozbehg commented 5 years ago

@bmalbuck thanks a lot Brian !!

ivnsch commented 5 years ago

Released 0.6.4