Support for Xcode 10.2 and Swift 5; addition of a universal target

ivnsch / SwiftCharts

Easy to use and highly customizable charts library for iOS

Apache License 2.0

2.53k stars 410 forks source link

Support for Xcode 10.2 and Swift 5; addition of a universal target #384

Closed bmalbuck closed 5 years ago

bmalbuck commented 5 years ago

Added SwiftChartsUniversal target that builds a fat binary with compile time arch stripping.
Migrate to Swift 5 while fixing deprecation warnings

ivnsch commented 5 years ago

Thanks @bmalbuck! Submitted a few comments, other than that it looks good. Thanks also @AgapovOne for helping to review!

bmalbuck commented 5 years ago

@i-schuetz I applied your suggested changes with one comment.

ivnsch commented 5 years ago

Thanks @bmalbuck and please next time update your branch with rebase instead of merge, to keep the history clean.

ivnsch commented 5 years ago

Also fixed the remaining warnings in the library project.

AgapovOne commented 5 years ago

@i-schuetz Why did you bumped minimum iOS version to 10.0? Library had 8.0 support, that's great. Why you've used 10.0 now?

ivnsch commented 5 years ago

? I didn't. Didn't notice this in the review.

AgapovOne commented 5 years ago

Sorry, it wasn't you. Checked merge in whole history, misjudged. This commit with universal target sets minimum target to 10.0. Downloaded last version, tried to reset to 8, successfully built a framework.

I think we should return it to 8.0.

@bmalbuck why you did that change?

ivnsch commented 5 years ago

Already changed it back and released a new version (0.6.5)!