search

ivoa-std / ADQL

Astronomical Data Query Language Standard
https://wiki.ivoa.net/twiki/bin/view/IVOA/ADQL
Creative Commons Attribution Share Alike 4.0 International
7 stars 7 forks source link

Fix IVOID of all geometrical features #75

Closed gmantele closed 1 year ago

gmantele commented 1 year ago

This Pull-Request fixes the IVOID of the language features for all geometrical functions.

ivo://ivoa.net/std/tapregext#features-adqlgeo

instead of

ivo://ivoa.net/std/tapregext#features-adql-geo

The IVOID of all other ADQL features starts with ivo://ivoa.net/std/tapregext#features-adql-. But for geometrical features it should not. Indeed, on the contrary to the other ADQL features, this one is already used in TAP services implementing a draft version of ADQL-2.1. This IVOID being already in existing in-production and IVOA registered services, it cannot be made consistent with the others ADQL language features ; this way, it avoids breaking existing services.

Fixes #71

gmantele commented 1 year ago

I wait for the #74 to be merged, before merging this one. This way, I will rebase it on top of #74 commits and complete the change log. Then, once reviewed and approved, I'll merge it with the master branch.

gmantele commented 1 year ago

Oh, and will you help me remember to push an updated TAPRegExt StandardsRegExt record with the next PR? That way, all the identifiers we define here will properly resolve, too.

Sure. Do you need a GitHub issue to remember it?

gmantele commented 1 year ago

By the way, @msdemlei, have you noticed that I put all IVOIDs in lower-case, especially the std/TAPRegExt# part?

In TAPRegExt-1.0, IVOIDs are written in mixed case (i.e. the TAPRegExt part). So, is it still ok to write that fully in lower case in ADQL-2.1?

msdemlei commented 1 year ago

On Thu, Mar 09, 2023 at 12:26:29AM -0800, Grégory Mantelet wrote:

By the way, @msdemlei, have you noticed that I put all IVOIDs in lower-case, especially the std/TAPRegExt# part?

In TAPRegExt-1.0, IVOIDs are written in mixed case (i.e. the TAPRegExt part). So, is it still ok to write that fully in lower case in ADQL-2.1?

Yeah, it's much better this way. Ivoids regrettably are case-insensitive, and giving them in mixed case then is inviting all kinds of grief. All-lowercase FTW.

msdemlei commented 1 year ago

On Thu, Mar 09, 2023 at 12:22:18AM -0800, Grégory Mantelet wrote:

Oh, and will you help me remember to push an updated TAPRegExt StandardsRegExt record with the next PR? That way, all the identifiers we define here will properly resolve, too.

Sure. Do you need a GitHub issue to remember it?

I don't think so -- if you follow the submission checklist while preparing the PR https://ivoa.net/documents/Notes/IVOATexDoc/20220525/NOTE-ivoatexDoc-1.3-20220525.html#tth_sEc3.12, you'll to the point

If uploading a REC or EN, update (or create) the standards record and send it to the RofR

-- and at that point just poke me, because (somewhat stupidly) the registry keys for ADQL are in TAPRegExt...