search

ivoa-std / CoordinateDM

Astronomical Coordinates and Coordinate Systems Data Model
1 stars 4 forks source link

ISOTime #16

Open pahjbo opened 1 year ago

pahjbo commented 1 year ago

The description of ISOTime says that the string representation follows FITS and drops the final Z that indicates UTC. I thought that this error had been corrected (and accepted) in the IVOA quite a long time ago. If something looks like an ISO time, is called an ISO time then it should follow the ISO rules. If you pass the bare time string to an iso time interpreting library on your computer then it will return a local time - which will possibly be incorrect depending on location and computer timezone setup

pahjbo commented 10 months ago

if the string representation definition is to be kept then it should be called FITSTime

mcdittmar commented 10 months ago

Paul, I'm on leave now for the next couple weeks, but wanted to say thanks for pinging this to the surface. I think that what is in the Coords model should agree with DALI, but I'm talking off the top of my head and that is risky. If we need to discuss a change/correction to what's in the document, hopefully others will chime in here.

Mark

On Thu, Dec 14, 2023 at 3:23 PM Paul Harrison @.***> wrote:

if the string representation definition is to be kept then it should be called FITSTime

— Reply to this email directly, view it on GitHub https://github.com/ivoa-std/CoordinateDM/issues/16#issuecomment-1856529485, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMLJCXVVVJ4SUKESC6AZFLYJNN4ZAVCNFSM6AAAAAAW6DZ2AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGUZDSNBYGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>