search

ivoa-std / DataLink

DataLink standard (DAL)
3 stars 6 forks source link

miscelaneaous service descriptor changes #24

Closed Bonnarel closed 4 years ago

Bonnarel commented 4 years ago

Miscelaneous service descriptor changes proposed by Mark Taylor. They are detailed in issues #20, #21, #22, #23

mbtaylor commented 4 years ago

The modified recommendations on how to author service descriptors addressing #21, #22, #23 are about right, but the examples have not been changed. These recommendations should be followed in the various service descriptor examples in the document to show what they look like in practice and by way of a template.

Bonnarel commented 4 years ago

The examples modified in the document available on the DAL wiki pages (page DataLink-next) were forgotten in previous version of #24. They  have been re-added in Pullrequest #34.

Conflicts appeared trying to modify pull request #24 which sounded to be unsolvable.

Le 23/11/2019 à 12:16, Mark Taylor a écrit :

The modified recommendations on how to author service descriptors addressing #21 https://github.com/ivoa-std/DataLink/issues/21, #22 https://github.com/ivoa-std/DataLink/issues/22, #23 https://github.com/ivoa-std/DataLink/issues/23 are about right, but the examples have not been changed. These recommendations should be followed in the various service descriptor examples in the document to show what they look like in practice and by way of a template.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ivoa-std/DataLink/pull/24?email_source=notifications&email_token=AMP5LTEJ6FVSDMVTOUWR4XLQVEGIJA5CNFSM4JDEEVGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE7S7SQ#issuecomment-557789130, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMP5LTCUMRRVUWLEVKWS27LQVEGIJANCNFSM4JDEEVGA.

msdemlei commented 4 years ago

I think this PR somehow broke; if I look at the diffs, I see it removes quite a bit of language, e.g., the one on the use of fragement identifiers, something on "and very important to help user distinguish links with same semantics" (where I'll say right now I'm not so overwhelmed by the "very important" in there), and the standardID INFO, while it apparently adds the "free name" on the service descriptor from PR #35. Could you rebuild the PR, making sure the diff is what you want it to be?

Bonnarel commented 4 years ago

I think this PR somehow broke; if I look at the diffs, I see it removes quite a bit of language, e.g., the one on the use of fragement identifiers, something on "and very important to help user distinguish links with same semantics" (where I'll say right now I'm not so overwhelmed by the "very important" in there), and the standardID INFO, while it apparently adds the "free name" on the service descriptor from PR #35. Could you rebuild the PR, making sure the diff is what you want it to be?

Bonnarel commented 4 years ago

Hi Markus, As stated above due to unsolvable conflicts when trying to modify the PR to add examples, I created a new PR #34 which reproduces correctly the content of this one. This one has to be closed.