search

ivoa-std / VOUnits

Units in the VO
Creative Commons Attribution Share Alike 4.0 International
0 stars 4 forks source link

Should standalone scalefactors be permitted as a ‘unit’: eg, `100`? #18

Closed nxg closed 11 months ago

nxg commented 2 years ago

This is found in some Vizier tables.

BaptisteCecconi commented 1 year ago

As discussed during the session, I think it would be good to support usual fractional non-dimensional units (e.g., ppm).

In astropy.units, it is not supported directly, you have to enable the CDS module first:

>>> from astropy.units import Unit
>>> from astropy.units import cds
>>> cds.enable()
>>> one_ppm = 1 * Unit('ppm')
>>> one_ppm
<Quantity 1. ppm>
>>> one_ppm.decompose()
<Quantity 1.e-06>
nxg commented 1 year ago

Since this issue has had no activity since last year, and (presumably) no conclusion was reached at the recent interop, I'd be inclined to close it, without supporting ppm and friends.

Any views, @BaptisteCecconi or @msdemlei ?

msdemlei commented 1 year ago

On Tue, Sep 12, 2023 at 09:58:47AM -0700, Norman Gray wrote:

Any views, @BaptisteCecconi or @msdemlei ?

Unless Baptiste protests loudly, I'd say let's close this and advise folks that we'll reconsider when someone re-opens the bug.