Closed jd-au closed 10 months ago
This commit looks harmless, but I don't see what it achieves - modulo insignificant whitespace it doesn't seem to make any changes. Looking at the LaTeX source, I wouldn't expect it to make a difference, and the PDF and HTML output look the same to me before and after the commit; in particular: I don't see a missing QUDT item name in the PDF or bold text after the affected item in the pre-commit HTML. Possibly I'm missing something...
Likewise, the pre-fix PDF and HTML look OK to me, so if there's a problem with the output, it may not lie with the document. Can we confirm where the problem is?
Actually, the QUDT item exists before and after the suggested commit, but what @jd-au wanted to fix is, according to me, the layout of this item.
Here is what the commit does once the PDF is compiled:
And here for the HTML version:
I'm sorry, Grégory, I'm still confused.
Modulo fine font and spacing details, the wording of the two versions of the QUDT item look the same to me. Are you saying that the Appendix B is missing in the PDF version you're seeing? When I compile the document, though (with the fix not applied), I see that appendix as expected. There's a page-break, but I don't think that's unexpected.
Here are the before images from https://ivoa.net/documents/VOUnits/20230502/index.html:
PDF (note the missing QUDT item name):
and from the HTML (note the missing QUDT item name and the bold text in section B
I was also very surprised that the missing whitespace caused this when I was tracing back the cause of the bolding in the HTML version.
Hmm: there's something else odd happening here. If I checkout revision 5683c18333 (which is the one before your fix, if I'm reading the runes correctly), and make VOUnits.pdf and VOUnits.html, I see
and
respectively. Is it possible there's something unusual in your working directory? Is the ivoatex
subrepo up to date? (I know there's dark magic involved there, to keep that at the right version, but make update
in the VOUnits working directory appears to be the recommended thing).
The newline in your fix really should make no difference, irrespective of the version of ivoatex
. I'm scratching my head here.
It'd be good to get to the bottom of this, because if there's some latent fragility in the build process, that's bad.
Ah, Mark had already fixed this in https://github.com/ivoa-std/VOUnits/pull/28 but that hasn't yet made it to the published PR on the IVOA site and there isn't an auto build of the current github repo state. I'll close this PR as not needed.
The QUDT item in appendix A.5 was missing the item name in the PDF, and all text after this section was bold in the HTML version.