search

ivoa / ivoa-web

ivoa.net website static web pages
Creative Commons Attribution Share Alike 4.0 International
3 stars 2 forks source link

Iss25: Add the applications page and remove broken links #26

Open andamian opened 2 months ago

molinaro-m commented 2 months ago

Wow! v/iss25 on the test site looks great! Why is this yet in draft?

JeremyMcCormick commented 2 months ago

Why is this yet in draft?

I believe the plan was to look at it during the hackathon and possibly get feedback from other participants.

I agree, this initial version looks very nice!

@andamian Does this remove all the dead links from the spreadsheet? (I assume so but just wanted to double check.)

andamian commented 2 months ago

Haven't started fixing any of the links. It's just the old content ported over md. Please double check that the issue correctly describes the scope of the problem so that we can start working on this when the time comes.

JeremyMcCormick commented 2 months ago

Haven't started fixing any of the links. It's just the old content ported over md.

Okay, thanks for clarifying. We can fix those in the hackathon.

Please double check that the issue correctly describes the scope of the problem so that we can start working on this when the time comes.

The issue is basically "add applications page and fix links" so scope seems fine to me. I don't see a problem doing it in one issue/PR.

I may show this PR during my overview of contributing, as it is a nice example. Thanks for starting this!

andamian commented 1 month ago

@molinaro-m, @JeremyMcCormick - this looks like the last remaining PR. I've added a couple of small updates to the existing version that we've managed to test in Sydney. So even if the test site is still down, I think this could be merged into main. What do you think?