Closed kovyrin closed 5 months ago
Just confirmed it was introduced in https://github.com/ivoanjo/gvl-tracing/commit/cafbeb7ff6383f6892947e7213542c09a8f155cc. The previous revision compiles without any issues.
Hey! Thanks for the report.
That failure is a bit... weird. threads.h
is from C11 and I'm assuming a modern macOS/Clang would support it. I wonder if it's because it needs some extra flags to allow access to those features.
Let me try a few things and see if I can understand why clang is unhappy...
So it turns out that for some bizarre reason macOS/Clang don't support all of C11, and in particular they decided they didn't like threads.h
.
And it also turns out that in my excitement to put out the release, I completely missed that the CI runs we have for the gem had already failed due to the missing threads.h
.
Thanks for catching and reporting this! I've pushed gvl-tracing 1.5.2 with a fix for the issue :)
Thank you for the fix. Just tested 1.5.2 installs correctly on my machine.
When installing the gem on a MacOS machine (MacOS Sonoma 14.4.1 (23E224)) with the latest XCode, I see the following error:
It seems to work as expected for my coworkers with older versions of XCode.
My gcc: