search

ivogabe / Brackets-Icons

File icons in Brackets' file tree
251 stars 59 forks source link

Update some icons and add QtQuick #77

Closed cgfrost closed 9 years ago

cgfrost commented 9 years ago

I've added some extra examples, the qml icon used for QtQuick files. I've also changed some defaults as I thought they could be more descriptive. Feel free to reject them if you prefer the existing defaults.

ivogabe commented 9 years ago

Thanks for the PR. I'd like to use Ionicons for all icons. (In the future I might add different icon 'packs', which will be based on different icon fonts. Currently other icon packs are included for users to easily customize certain icons.) Can you revert the changes to the icons from devicons? About the JavaScript icon, in my opinion ion-social-javascript doesn't fit with the other icons. The color change (.es6) is ok to me.

cgfrost commented 9 years ago

Sure, no problem. I'll update the pull request. I use a dark theme the my es6 icons were almost invisible, glad that's OK.

cgfrost commented 9 years ago

Everything is using Ionicons now and the JS icons are back to the original defaults. I've updated the readme as well now. Very happy to change anything else you want, thanks for the quick review earlier.

cgfrost commented 9 years ago

Actually, I'm being a little lazy. Would you like me to split this out in to separate pull requests?

ivogabe commented 9 years ago

A single PR isn't a problem, but can you add icons in different commits? I can then easily choose the commits I want to merge.

Can you revert the ruby icon? The heart looks a bit like the logo of ruby. About the sh and bat icons, I agree that the current isn't the best, but I'm not sure which we should use. ion-android-desktop is in my opinion still not the best, maybe ion-android-list?

cgfrost commented 9 years ago

Hi,

I've split it out in to separate commits and made the changes you asked for. I also agree that ion-android-list is better than my suggestion and I think it's better then the previous choice.

ivogabe commented 9 years ago

Thanks! It's almost good to merge, I found two small things. When you've fixed these, I'll merge in your changes.

cgfrost commented 9 years ago

Thanks again for the quick response, I have made the changes/fixes. (Indentation error was a little amateur). Happy to make more changes if you want them.

ivogabe commented 9 years ago

Thanks! Merged