search

ivogabe / Brackets-Icons

File icons in Brackets' file tree
251 stars 59 forks source link

files with two extensions show both icons. #84

Closed wormeyman closed 9 years ago

wormeyman commented 9 years ago

image

for example the .exe.config file but if you try this with other file types it doesn't always happen for example .csv.xml looks normal but .html.js shows both icons.

ivogabe commented 9 years ago

That's actually by design, it was introduced in the latest release. It only happens to known files, for instance .exe, .js and .html are supported extensions, but .csv not (but you can of course create a PR if you want that icon too). The alignment is a bit off at the moment, but that will be addressed in the next version (see #81).

cgfrost commented 9 years ago

In the examples folder I can see this happening on files that have the same name as the extension, for example ico.ico, yaml.yml and svg.svg. Is that by design as well or a bug? I suspect that it shouldn't happen in that case.

I have just realized that this is happening to icons I have custom definitions for in my brackets.json file, there may be a bug in the handling of user defined icons then.

ivogabe commented 9 years ago

@cgfrost I agree that that isn't desired, I'll try to filter these out.

ivogabe commented 9 years ago

@cgfrost Solved in 7efcb3893c677ed096dfded5e36245690da03b42

ivogabe commented 9 years ago

The next version has an option to hide secondary icons (#86) and fixes formatting (#81).